Conversation
Not all postgres hosted services use `postgres` Also rename `database` config parameter to `vss_database`
|
👋 Thanks for assigning @tankyleo as a reviewer! |
|
🔔 1st Reminder Hey @tankyleo! This PR has been waiting for your review. |
|
🔔 2nd Reminder Hey @tankyleo! This PR has been waiting for your review. |
|
🔔 3rd Reminder Hey @tankyleo! This PR has been waiting for your review. |
tankyleo
left a comment
tankyleo
left a comment
There was a problem hiding this comment.
Thanks ! can you make this one commit / remove the merge commit in the current PR ?
tankyleo
left a comment
tankyleo
left a comment
There was a problem hiding this comment.
As mentioned above, let's bring back ca-certificates for HTTPS requests.
Also squash all the commits into a single one.
The RSA public key against which the JWT tokens are verified can be set either via a configuration file setting, or an environment variable, with the latter having the higher priority. copy vss-server-config.toml remove ca-certificates rever removal of ca-certificates
frnandu
force-pushed
the
chore/rust-dockerfile
branch
from
19a5f86 to
8acc598
Compare
frnandu
force-pushed
the
chore/rust-dockerfile
branch
2 times, most recently
from
fcec5ff to
2336a2d
Compare
Isn't that possible to do when merging by |
I need to ACK the exact commit that will get merged, should be quite doable on your side no ? |
|
@frnandu making sure you see this message above thanks for squashing if you can |
frnandu
force-pushed
the
chore/rust-dockerfile
branch
from
2336a2d to
7f34829
Compare
|
Squashed, thanks! |
tankyleo
left a comment
tankyleo
left a comment
There was a problem hiding this comment.
Thanks tested on my machine looks good.
One last nitpick before merge: please set the title to Add rust Dockerfile, no need for the chore prefix thank you, I want to keep the commit log consistent.
frnandu
force-pushed
the
chore/rust-dockerfile
branch
from
7f34829 to
2bbc54c
Compare
done |
4 participants
fixes #74